Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename L1FeeEnabled to FeeVaultEnabled #281

Merged
merged 2 commits into from Apr 19, 2023
Merged

Conversation

HAOYUatHZ
Copy link
Member

@HAOYUatHZ HAOYUatHZ commented Apr 18, 2023

to address #262 (comment)

@HAOYUatHZ HAOYUatHZ requested a review from icemelon April 18, 2023 01:25
@colinlyguo
Copy link
Member

I left a new comment in the last merged PR: blockTrace.WithdrawTrieRoot = withdrawtrie.ReadWTRSlot(rcfg.L2MessageQueueAddress, env.state) is not controlled by any config now. Is it compatible with other geth configs?

@HAOYUatHZ
Copy link
Member Author

HAOYUatHZ commented Apr 19, 2023

I left a new comment in the last merged PR: blockTrace.WithdrawTrieRoot = withdrawtrie.ReadWTRSlot(rcfg.L2MessageQueueAddress, env.state) is not controlled by any config now. Is it compatible with other geth configs?

I think we don't need to be compatible with other geth config.
and by default ReadWTRSlot will return 0 if we don't set up L2MessageQueue contract?

but yeah I do agree it will be great if it can be "controlled by some config"
we can leave it as a future improvement

@HAOYUatHZ HAOYUatHZ merged commit 11ff7a0 into develop Apr 19, 2023
3 checks passed
@HAOYUatHZ HAOYUatHZ deleted the consolidate branch April 19, 2023 14:41
@colinlyguo
Copy link
Member

I left a new comment in the last merged PR: blockTrace.WithdrawTrieRoot = withdrawtrie.ReadWTRSlot(rcfg.L2MessageQueueAddress, env.state) is not controlled by any config now. Is it compatible with other geth configs?

I think we don't need to be compatible with other geth config. and by default ReadWTRSlot will return 0 if we don't set up L2MessageQueue contract?

but yeah I do agree it will be great if it can be "controlled by some config" we can leave it as a future improvement

oh, I see, then this modification makes sense since it's just used as a scroll geth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants