Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade txpool module to increase tps #43

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Upgrade txpool module to increase tps #43

merged 1 commit into from
Mar 21, 2022

Conversation

mask-pp
Copy link

@mask-pp mask-pp commented Mar 16, 2022 •
edited
Loading

More detail please refer the doc.

@ChuhanJin
Copy link

Can one of the admins verify this patch?

@HAOYUatHZ
Copy link
Member

HAOYUatHZ commented Mar 16, 2022 •
edited
Loading

will also be great to record tps before vs after in the PR description

@mask-pp
Copy link
Author

mask-pp commented Mar 16, 2022

will also be great to record tps before vs after in the PR description

ALready added the description！

hsyodyssey
hsyodyssey reviewed Mar 18, 2022
View reviewed changes
Copy link

@hsyodyssey hsyodyssey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Huan, as I understand it, this PR is trying to reduce GC pressure by reducing the declaration of large data structures, such as spammers. Logically this is very reasonable.

I have a small concern because spammers seems like not a thread-safe priority queue. But it seems the txpool will be locked by https://github.com/mask-pp/go-ethereum/blob/up_tps/core/tx_pool.go#L1172?  If so, looks good to me.

@mask-pp
Copy link
Author

mask-pp commented Mar 18, 2022 •
edited
Loading

The used place of pool.spammers is in truncatePending func, and truncatePending locked in the pool.mu.lock() pool.mu.Unlock() area. So it's safe.

@mask-pp mask-pp merged commit 09a31cc into scroll-tech:zkrollup Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HAOYUatHZ HAOYUatHZ HAOYUatHZ approved these changes

@hsyodyssey hsyodyssey hsyodyssey approved these changes

@icemelon icemelon Awaiting requested review from icemelon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mask-pp @ChuhanJin @HAOYUatHZ @hsyodyssey