Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(miner): consider l1msg in txCount #486

Merged
merged 14 commits into from
Aug 26, 2023
Merged

feat(miner): consider l1msg in txCount #486

merged 14 commits into from
Aug 26, 2023

Conversation

HAOYUatHZ
Copy link
Member

@HAOYUatHZ HAOYUatHZ commented Aug 26, 2023

1. Purpose or design rationale of this PR

...

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Copy link
Member

@icemelon icemelon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remember to update the validation rules

miner/worker.go Outdated Show resolved Hide resolved
@colinlyguo colinlyguo marked this pull request as ready for review August 26, 2023 06:16
@colinlyguo colinlyguo self-assigned this Aug 26, 2023
colinlyguo
colinlyguo previously approved these changes Aug 26, 2023
@colinlyguo colinlyguo removed their assignment Aug 26, 2023
@colinlyguo colinlyguo self-requested a review August 26, 2023 09:19
Thegaram
Thegaram previously approved these changes Aug 26, 2023
miner/worker.go Outdated Show resolved Hide resolved
miner/worker_test.go Outdated Show resolved Hide resolved
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Thegaram
Thegaram previously approved these changes Aug 26, 2023
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please bump version

@HAOYUatHZ HAOYUatHZ merged commit d650299 into develop Aug 26, 2023
5 checks passed
@HAOYUatHZ HAOYUatHZ deleted the l1msg branch August 26, 2023 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants