Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libzkp): upgrade to v0.8.2 #504

Merged
merged 4 commits into from
Sep 7, 2023
Merged

fix(libzkp): upgrade to v0.8.2 #504

merged 4 commits into from
Sep 7, 2023

Conversation

silathdiir
Copy link

@silathdiir silathdiir commented Sep 7, 2023

1. Purpose or design rationale of this PR

fix to row_number <= NORMALIZED_ROW_LIMIT.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@silathdiir silathdiir changed the title [don't-merge] test ccc [Testing] libzkp-v0.8.2 (fix to row_number <= NORMALIZED_ROW_LIMIT) Sep 7, 2023
@silathdiir silathdiir changed the title [Testing] libzkp-v0.8.2 (fix to row_number <= NORMALIZED_ROW_LIMIT) [Testing] libzkp-v0.8.2 Sep 7, 2023
@silathdiir
Copy link
Author

ccc-tester could work.

Screen Shot 2023-09-07 at 1 51 58 PM

@silathdiir silathdiir changed the title [Testing] libzkp-v0.8.2 libzkp-v0.8.2 Sep 7, 2023
@HAOYUatHZ HAOYUatHZ changed the title libzkp-v0.8.2 fix(libzkp): upgrade to v0.8.2 Sep 7, 2023
@scroll-dev scroll-dev merged commit c75ebdb into develop Sep 7, 2023
5 checks passed
@scroll-dev scroll-dev deleted the test-ccc branch September 7, 2023 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants