Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(libzkp): upgrade libzkp to v0.9.4 and add ccc SetLightMode #522

Merged
merged 7 commits into from
Oct 3, 2023

Conversation

silathdiir
Copy link

@silathdiir silathdiir commented Sep 23, 2023

1. Purpose or design rationale of this PR

  • upgrade prover to v0.9.4.
  • add ccc function SetLightMode.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

Thegaram
Thegaram previously approved these changes Sep 23, 2023
johnsonjie
johnsonjie previously approved these changes Sep 23, 2023
georgehao
georgehao previously approved these changes Sep 23, 2023
@silathdiir silathdiir changed the title fix(libzkp): upgrade libzkp to v0.9.3 [WIP] fix(libzkp): upgrade libzkp to v0.9.4 Sep 27, 2023
@silathdiir silathdiir marked this pull request as draft September 27, 2023 07:21
@silathdiir silathdiir changed the title [WIP] fix(libzkp): upgrade libzkp to v0.9.4 [WIP] fix(libzkp): upgrade libzkp to v0.9.4 and add ccc SetLightMode Sep 27, 2023
@lispc lispc marked this pull request as ready for review September 27, 2023 11:39
@silathdiir silathdiir changed the title [WIP] fix(libzkp): upgrade libzkp to v0.9.4 and add ccc SetLightMode fix(libzkp): upgrade libzkp to v0.9.4 and add ccc SetLightMode Sep 27, 2023
Thegaram
Thegaram previously approved these changes Oct 3, 2023
@Thegaram Thegaram merged commit 7cebee8 into develop Oct 3, 2023
5 checks passed
@Thegaram Thegaram deleted the libzkp-v0.9.3 branch October 3, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants