Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add metrics around block commit, block traces, and CCC #552

Merged
merged 7 commits into from
Nov 9, 2023

Conversation

vyzo
Copy link

@vyzo vyzo commented Nov 7, 2023

As the tile suggests, this adds 3 metrics for tracking timings and providing visibility around Block commit and CCC:

  • The first metric is the aggregate time taken to commit a block
  • The second metric is the time taken to compute the trace for a single tx
  • The third metric is the the time taken to run CCC for a single tx trace

@vyzo vyzo requested a review from Thegaram November 7, 2023 18:58
Copy link

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bump version in params/version.go

miner/worker.go Outdated Show resolved Hide resolved
miner/worker.go Show resolved Hide resolved
miner/worker.go Outdated Show resolved Hide resolved
@Thegaram
Copy link

Thegaram commented Nov 8, 2023

Other operations to consider:

  • Result handling in resultLoop (including rawdb.WriteBlockRowConsumption).
  • One additional tracing + CCC call in commit.
  • w.collectPendingL1Messages in commitNewWork.

Thegaram
Thegaram previously approved these changes Nov 8, 2023
Copy link
Member

@colinlyguo colinlyguo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Thegaram Thegaram merged commit 65a3a7f into develop Nov 9, 2023
5 checks passed
@Thegaram Thegaram deleted the feat/ccc-metrics branch November 9, 2023 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants