Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docker): make sure the libzkp directory is clean #664

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Mar 11, 2024

might have artifacts already built on the host machine

might have artifacts already built on the host machine
@HAOYUatHZ
Copy link
Member

if cargo.lock is changed it will rebuild.
if unchanged we don't need to rebuild.
no?

@omerfirmak
Copy link
Author

While building the docker image, cargo tried to use some arm64 binaries that it copied over from my laptop to the docker image. Which resulted in a linking error since my laptop is arm64, but the docker image target is x86_64. This is the only reliable way I could think of tbh.

@HAOYUatHZ HAOYUatHZ merged commit df83a62 into develop Mar 20, 2024
6 checks passed
@HAOYUatHZ HAOYUatHZ deleted the omerfirmak/docker-arm64 branch March 20, 2024 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants