Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add more state_transition, worker, and tracing metrics #700

Merged
merged 31 commits into from
Apr 16, 2024

Conversation

georgehao
Copy link
Member

@georgehao georgehao commented Apr 14, 2024

1. Purpose or design rationale of this PR

image

getBlockTrace cost: 149ms
ccc applyTransaction: 295 ms
total cost : 4.5s

4500/(149+295+1) = 10

namely, commitTransactions parameter txs contains 10 tx, I think almost the real data. So if we can optimize this two function, the CommitTransactions performance will improved

image

Currently, the commitTransactions all cost at getBlockTrace and ccc applyTransaction.

This pr add metrics to investigate the cost of getBlockTrace

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@georgehao georgehao changed the title Feat/add metrics of worker (worker):add metrics of worker Apr 14, 2024
@georgehao georgehao marked this pull request as ready for review April 14, 2024 16:56
colinlyguo
colinlyguo previously approved these changes Apr 15, 2024
omerfirmak
omerfirmak previously approved these changes Apr 15, 2024
Thegaram
Thegaram previously approved these changes Apr 15, 2024
rollup/tracing/tracing.go Show resolved Hide resolved
@Thegaram Thegaram changed the title (worker):add metrics of worker feat(worker): add more state_transition, worker, and tracing metrics Apr 15, 2024
@Thegaram Thegaram changed the title feat(worker): add more state_transition, worker, and tracing metrics feat: add more state_transition, worker, and tracing metrics Apr 15, 2024
@georgehao georgehao dismissed stale reviews from Thegaram and omerfirmak via 414c258 April 15, 2024 16:16
HAOYUatHZ
HAOYUatHZ previously approved these changes Apr 16, 2024
colinlyguo
colinlyguo previously approved these changes Apr 16, 2024
miner/worker.go Outdated Show resolved Hide resolved
miner/worker.go Show resolved Hide resolved
miner/worker.go Show resolved Hide resolved
Co-authored-by: colin <102356659+colinlyguo@users.noreply.github.com>
colinlyguo
colinlyguo previously approved these changes Apr 16, 2024
HAOYUatHZ
HAOYUatHZ previously approved these changes Apr 16, 2024
@HAOYUatHZ
Copy link
Member

probably also need to bump version

@colinlyguo
Copy link
Member

@HAOYUatHZ we found two small problems in the bump version bot: (i) will bump patch version in each commit without comparing the develop branch. (ii) unverified commit, thus stuck the CI.

This reverts commit 175d544.
@georgehao georgehao merged commit 678a9fc into develop Apr 16, 2024
7 checks passed
@georgehao georgehao deleted the feat/add_metrics_of_worker branch April 16, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants