Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use a named deadline timer in CCC stage #782

Merged
merged 3 commits into from
May 30, 2024

Conversation

omerfirmak
Copy link

1. Purpose or design rationale of this PR

timers implicitly created by time.After() don't get collected until they fire.

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@HAOYUatHZ
Copy link
Member

if you want to deploy it, do you need to bump the version?

@omerfirmak
Copy link
Author

if you want to deploy it, do you need to bump the version?

done, thanks!

HAOYUatHZ
HAOYUatHZ previously approved these changes May 29, 2024
colinlyguo
colinlyguo previously approved these changes May 29, 2024
HAOYUatHZ
HAOYUatHZ previously approved these changes May 30, 2024
@github-actions github-actions bot dismissed stale reviews from colinlyguo and HAOYUatHZ via a8306ab May 30, 2024 00:29
jonastheis
jonastheis previously approved these changes May 30, 2024
rollup/pipeline/pipeline.go Show resolved Hide resolved
rollup/pipeline/pipeline.go Outdated Show resolved Hide resolved
@omerfirmak omerfirmak merged commit 094a67a into develop May 30, 2024
@omerfirmak omerfirmak deleted the omerfirmak/deadline-timer branch May 30, 2024 06:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants