Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(prometheus): collect timer.Total() #817

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

omerfirmak
Copy link

@omerfirmak omerfirmak commented Jun 11, 2024

1. Purpose or design rationale of this PR

prometheus equivalent of #772

2. PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

3. Deployment tag versioning

Has the version in params/version.go been updated?

  • This PR doesn't involve a new deployment, git tag, docker image tag, and it doesn't affect traces
  • Yes

4. Breaking change label

Does this PR have the breaking-change label?

  • This PR is not a breaking change
  • Yes

@Thegaram Thegaram merged commit e34a8cf into develop Jun 11, 2024
8 checks passed
@Thegaram Thegaram deleted the omerfirmak/prometheus-timer branch June 11, 2024 11:12
@omerfirmak omerfirmak mentioned this pull request Jun 12, 2024
13 tasks
HAOYUatHZ pushed a commit that referenced this pull request Aug 1, 2024
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
HAOYUatHZ added a commit that referenced this pull request Aug 1, 2024
feat(prometheus): collect timer.Total() (#817)

Co-authored-by: Ömer Faruk Irmak <omerfirmak@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants