Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scroll-dev-0607: add circuit aggregation #16

Merged
merged 12 commits into from
Jul 19, 2022
Merged

scroll-dev-0607: add circuit aggregation #16

merged 12 commits into from
Jul 19, 2022

Conversation

lispc
Copy link
Collaborator

@lispc lispc commented Jun 23, 2022

cargo test --features prove_verify --release test_4in1

peak mem: 506G
wallet clock time: 6809.25s

notable changes:

  1. create_agg_circuit_proof will be the real public method of prover. The old proving evm circuit / state circuit are "inner" now.
  2. Although we init evm / state vks in verifier, they are kept only for legacy reasons. They are not needed any longer in fact.
  3. Roller/Verifier service need some pregenerated files: params18 / params26 / verify_circuit.vkey(Verifier only). params18/26 are stored in a EC2 now. Need to publish onto S3 later.
  4. no longer give BockResult to verifier. Verifier should not access BlockResult.
  5. MISC: test_params changed from file to folder; AggCircuitProof is the data that should be passed from prover to verifier.
  6. solidity stuff: see this example https://github.com/scroll-tech/halo2-snark-aggregator/blob/scroll-dev-0607/halo2-snark-aggregator-solidity/waffle/run.sh AggCircuitProof::proof_solidity(named proof_be in disk) and AggCircuitProof::instances_commitments needed for solidity. This file is THE VERIFIER released.

@lispc lispc force-pushed the scroll-dev-0607 branch 2 times, most recently from 7012882 to c95d00b Compare June 23, 2022 11:43
@lispc lispc changed the title wip add aggregation circuit add aggregation circuit Jul 7, 2022
@scroll-dev scroll-dev changed the title add aggregation circuit feat: add circuit aggregation Jul 19, 2022
@scroll-dev scroll-dev merged commit 8c0815f into main Jul 19, 2022
@scroll-dev scroll-dev deleted the scroll-dev-0607 branch July 19, 2022 03:02
@lispc lispc changed the title feat: add circuit aggregation scroll-dev-0607: add circuit aggregation Jul 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants