fix(contracts): OZ-L2-M02 WETH9 Approval Can Be Front-Run (#632)

Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
scroll-tech · Jul 24, 2023 · 0fc6d2a · 0fc6d2a
1 parent 0ce3b18
commit 0fc6d2a
Show file tree

Hide file tree

Showing 5 changed files with 66 additions and 801 deletions.
diff --git a/contracts/hardhat.config.ts b/contracts/hardhat.config.ts
@@ -116,7 +116,7 @@ const config: HardhatUserConfig = {
       "IL2ERC1155Gateway",
       "IScrollStandardERC20Factory",
       "IZKRollup",
-      "WETH9",
+      "WrappedEther",
     ],
   },
 };

diff --git a/contracts/scripts/deploy_weth.ts b/contracts/scripts/deploy_weth.ts
@@ -10,8 +10,8 @@ async function main() {
 
   if (!addressFile.get("WETH")) {
     console.log(">> Deploy WETH");
-    const WETH9 = await ethers.getContractFactory("WETH9", deployer);
-    const weth = await WETH9.deploy();
+    const WrappedEther = await ethers.getContractFactory("WrappedEther", deployer);
+    const weth = await WrappedEther.deploy();
     console.log(`>> waiting for transaction: ${weth.deployTransaction.hash}`);
     await weth.deployed();
     console.log(`✅ WETH deployed at ${weth.address}`);

diff --git a/contracts/scripts/foundry/DeployWeth.s.sol b/contracts/scripts/foundry/DeployWeth.s.sol
@@ -1,30 +1,30 @@
 // SPDX-License-Identifier: UNLICENSED
 pragma solidity ^0.8.10;
 
-import { Script } from "forge-std/Script.sol";
-import { console } from "forge-std/console.sol";
+import {Script} from "forge-std/Script.sol";
+import {console} from "forge-std/console.sol";
 
-import { WETH9 } from "../../src/L2/predeploys/WETH9.sol";
+import {WrappedEther} from "../../src/L2/predeploys/WrappedEther.sol";
 
 contract DeployWeth is Script {
-  address L1_WETH_ADDR = vm.envAddress("L1_WETH_ADDR");
-  address L2_WETH_ADDR = vm.envAddress("L2_WETH_ADDR");
+    address L1_WETH_ADDR = vm.envAddress("L1_WETH_ADDR");
+    address L2_WETH_ADDR = vm.envAddress("L2_WETH_ADDR");
 
-  function run() external {
-    // deploy weth only if we're running a private L1 network
-    if (L1_WETH_ADDR == address(0)) {
-      uint256 L1_WETH_DEPLOYER_PRIVATE_KEY = vm.envUint("L1_WETH_DEPLOYER_PRIVATE_KEY");
-      vm.startBroadcast(L1_WETH_DEPLOYER_PRIVATE_KEY);
-      WETH9 weth = new WETH9();
-      L1_WETH_ADDR = address(weth);
-      vm.stopBroadcast();
-    }
+    function run() external {
+        // deploy weth only if we're running a private L1 network
+        if (L1_WETH_ADDR == address(0)) {
+            uint256 L1_WETH_DEPLOYER_PRIVATE_KEY = vm.envUint("L1_WETH_DEPLOYER_PRIVATE_KEY");
+            vm.startBroadcast(L1_WETH_DEPLOYER_PRIVATE_KEY);
+            WrappedEther weth = new WrappedEther();
+            L1_WETH_ADDR = address(weth);
+            vm.stopBroadcast();
+        }
 
-    logAddress("L1_WETH_ADDR", L1_WETH_ADDR);
-    logAddress("L2_WETH_ADDR", L2_WETH_ADDR);
-  }
+        logAddress("L1_WETH_ADDR", L1_WETH_ADDR);
+        logAddress("L2_WETH_ADDR", L2_WETH_ADDR);
+    }
 
-  function logAddress(string memory name, address addr) internal view {
-    console.log(string(abi.encodePacked(name, "=", vm.toString(address(addr)))));
-  }
+    function logAddress(string memory name, address addr) internal view {
+        console.log(string(abi.encodePacked(name, "=", vm.toString(address(addr)))));
+    }
 }