fix(contracts): OZ-L01 Implementation Keeps Functionalities for Deprecated Variables

[zimpha]

Purpose or design rationale of this PR

This PR fix the following issue reported by Openzepplin: L-01 Implementation Keeps Functionalities for Deprecated Variables

At line 82 of L1GatewayRouter.sol, it is explained that the ethGateway parameter is no longer in use. However, the logic that makes use of/changes this variable, such as the check in the initialize function and the setETHGateway function, is maintained.

If a variable is no longer in use, consider removing the logic that uses it.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

• No, this PR doesn't involve a new deployment, git tag, docker image tag
• Yes

Breaking change label

Does this PR have the breaking-change label?

• No, this PR is not a breaking change
• Yes

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1901a32) 57.07% compared to head (223538d) 57.03%.
Report is 1 commits behind head on develop.

❗ Current head 223538d differs from pull request most recent head 0705fb1. Consider uploading reports for the commit 0705fb1 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1094      +/-   ##
===========================================
- Coverage    57.07%   57.03%   -0.05%     
===========================================
  Files          150      150              
  Lines        11196    11148      -48     
===========================================
- Hits          6390     6358      -32     
+ Misses        4361     4346      -15     
+ Partials       445      444       -1     

Flag	Coverage Δ
contracts	57.43% <ø> (-0.11%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Thegaram]

I'd recommend removing setETHGateway. Other than that it looks good.