-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): 4844 support #1179
Conversation
027a607
to
25f32b5
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1179 +/- ##
===========================================
- Coverage 56.79% 56.40% -0.40%
===========================================
Files 155 157 +2
Lines 11848 11968 +120
===========================================
+ Hits 6729 6750 +21
- Misses 4613 4712 +99
Partials 506 506
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Do we need a |
we can add one after this PR merged |
Fyi I added this on https://github.com/scroll-tech/scroll/tree/feat/4844-skip-proof-for-local-testing for local testing. But eventually we'll need to push this code to the |
Cool. FYI, the rollup-relayer has supported and tested finalizeBatch4844 (when timeout, without proof) in your commit, too. |
Purpose or design rationale of this PR
Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated or have you addedbump-version
label to this PR?Breaking change label
Does this PR have the
breaking-change
label?