Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): fix number of non-skipped l1 messages #1232

Merged
merged 2 commits into from Apr 3, 2024

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Apr 3, 2024

Purpose or design rationale of this PR

This PR fix the logic to compute the number of non-skipped l1 messages in each block.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 56.35%. Comparing base (790fc44) to head (67ff2bd).

Files Patch % Lines
contracts/src/L1/rollup/ScrollChain.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1232      +/-   ##
===========================================
+ Coverage    56.25%   56.35%   +0.09%     
===========================================
  Files          158      158              
  Lines        12304    12304              
===========================================
+ Hits          6922     6934      +12     
+ Misses        4845     4833      -12     
  Partials       537      537              
Flag Coverage Δ
contracts 55.82% <0.00%> (+0.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@HAOYUatHZ HAOYUatHZ merged commit f8a7d70 into develop Apr 3, 2024
11 checks passed
@HAOYUatHZ HAOYUatHZ deleted the fix/compute_total_txs_in_chunk branch April 3, 2024 03:10
HAOYUatHZ added a commit that referenced this pull request Apr 3, 2024
Co-authored-by: HAOYUatHZ <37070449+HAOYUatHZ@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants