Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Implemented fixes for 4844 support fix review. #1256

Merged
merged 1 commit into from Apr 10, 2024

Conversation

spilehchiha
Copy link
Contributor

Purpose or design rationale of this PR

What does this PR do?
This PR implements fixes re: 4844-support review.

Why does it do it?
Because security reviews need to be reflected In the code.

How does it do it?
By changing the code when necessary.

fix: Implemented fixes for 4844 support fix review.

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.20%. Comparing base (3d5250e) to head (5425ce7).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1256   +/-   ##
========================================
  Coverage    56.20%   56.20%           
========================================
  Files          154      154           
  Lines        12002    12002           
========================================
  Hits          6746     6746           
  Misses        4739     4739           
  Partials       517      517           
Flag Coverage Δ
contracts 55.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@spilehchiha spilehchiha merged commit b3093e9 into develop Apr 10, 2024
11 checks passed
@spilehchiha spilehchiha deleted the fix-review-4844-support branch April 10, 2024 10:05
@roylou roylou added the bug Something isn't working label Apr 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants