Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update codec version #1448

Merged
merged 16 commits into from
Jul 18, 2024
Merged

update codec version #1448

merged 16 commits into from
Jul 18, 2024

Conversation

georgehao
Copy link
Member

Purpose or design rationale of this PR

Describe your change. Make sure to answer these three questions: What does this PR do? Why does it do it? How does it do it?

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 42.65734% with 82 lines in your changes missing coverage. Please review.

Please upload report for BASE (feat/upgrade4@c34883e). Learn more about missing BASE report.

Files Patch % Lines
...llup/internal/controller/watcher/batch_proposer.go 38.46% 22 Missing and 2 partials ⚠️
...llup/internal/controller/watcher/chunk_proposer.go 39.47% 21 Missing and 2 partials ⚠️
rollup/internal/utils/utils.go 0.00% 22 Missing ⚠️
bridge-history-api/internal/utils/utils.go 70.45% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             feat/upgrade4    #1448   +/-   ##
================================================
  Coverage                 ?   52.67%           
================================================
  Files                    ?      157           
  Lines                    ?    12527           
  Branches                 ?        0           
================================================
  Hits                     ?     6599           
  Misses                   ?     5367           
  Partials                 ?      561           
Flag Coverage Δ
bridge-history-api 71.16% <70.45%> (?)
common 49.61% <ø> (?)
coordinator 17.53% <ø> (?)
database 42.85% <ø> (?)
rollup 57.14% <30.30%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@georgehao georgehao merged commit 74c197e into feat/upgrade4 Jul 18, 2024
16 checks passed
@georgehao georgehao deleted the feat/upgrade_codec_version branch July 18, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants