Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test:bump l2geth docker version #455

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

mask-pp
Copy link
Contributor

@mask-pp mask-pp commented May 8, 2023

  1. Purpose or design rationale of this PR
    Update l2geth image version up to scroll-v3.1.4.

  2. Does this PR involve a new deployment, and involve a new git tag & docker image tag? If so, has tag in common/version.go been updated?
    No.

  3. Is this PR a breaking change? If so, have it been attached a breaking-change label?
    No.

@scroll-dev
Copy link
Contributor

58% (+12.45%) vs master 45%

Copy link
Contributor

@Thegaram Thegaram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update genesis.json to follow scroll-tech/go-ethereum#262. You can reference this (without maxTxPayloadBytesPerBlock):

"scroll": {
  "useZktrie": true,
  "maxTxPerBlock": 44,
  "feeVaultAddress": "0x5300000000000000000000000000000000000005",
  "enableEIP2718": false,
  "enableEIP1559": false
}

@mask-pp
Copy link
Contributor Author

mask-pp commented May 8, 2023

But in l2geth@scroll-v3.1.4 branch has no scroll field. Should I still need to update it?

@mask-pp
Copy link
Contributor Author

mask-pp commented May 8, 2023

But in l2geth@scroll-v3.1.4 branch has no scroll field. Should I still need to update it?

l2geth@scroll-v3.1.11 is ok.

@Thegaram
Copy link
Contributor

Thegaram commented May 8, 2023

But in l2geth@scroll-v3.1.4 branch has no scroll field. Should I still need to update it?

It has the "scroll" field: https://github.com/scroll-tech/go-ethereum/blob/49e755e33417c7f32715e759150fec0fd1224306/params/config.go#L424

@mask-pp
Copy link
Contributor Author

mask-pp commented May 8, 2023

But in l2geth@scroll-v3.1.4 branch has no scroll field. Should I still need to update it?

It has the "scroll" field: https://github.com/scroll-tech/go-ethereum/blob/49e755e33417c7f32715e759150fec0fd1224306/params/config.go#L424

Ok, get it.

@mask-pp
Copy link
Contributor Author

mask-pp commented May 8, 2023

Need to update genesis.json to follow scroll-tech/go-ethereum#262. You can reference this (without maxTxPayloadBytesPerBlock):

"scroll": {
  "useZktrie": true,
  "maxTxPerBlock": 44,
  "feeVaultAddress": "0x5300000000000000000000000000000000000005",
  "enableEIP2718": false,
  "enableEIP1559": false
}

changed.

@scroll-dev
Copy link
Contributor

58% (+12.45%) vs master 45%

@HAOYUatHZ HAOYUatHZ changed the title bump l2geth version test:bump l2geth docker version May 8, 2023
@HAOYUatHZ HAOYUatHZ merged commit b4d8e5f into develop May 8, 2023
3 checks passed
@HAOYUatHZ HAOYUatHZ deleted the feat/bump_l2geth_version branch May 8, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants