Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): fix chunk hash computation #546

Merged
merged 2 commits into from Jun 8, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Jun 7, 2023

Purpose or design rationale of this PR

This PR fix a bug related to chunk data hash computation. During committing chunk, we will call L1MessageQueue for l1 message hash, which will corrupt the memory at 0x40. So we need to manually reserve memory for chunk data hash payload.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
  • ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
  • docs: Documentation-only changes
  • feat: A new feature
  • fix: A bug fix
  • perf: A code change that improves performance
  • refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
  • test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha added the bug Something isn't working label Jun 7, 2023
@zimpha zimpha self-assigned this Jun 7, 2023
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

LCOV of commit add52da during Contracts #788

Summary coverage rate:
  lines......: 46.7% (741 of 1587 lines)
  functions..: 57.3% (153 of 267 functions)
  branches...: no data found

Files changed coverage rate: n/a

@HAOYUatHZ HAOYUatHZ requested a review from rrzhang139 June 7, 2023 06:59
@HAOYUatHZ HAOYUatHZ merged commit fb44382 into develop Jun 8, 2023
3 checks passed
@HAOYUatHZ HAOYUatHZ deleted the bugfix/compute_chunk_data_hash branch June 8, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants