fix(contracts): bug fixing based on openzeppelin's audit #558
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose or design rationale of this PR
This PR fix bugs found in openzeppelin's audit
0x80
to encoderlp(0)
0x80
to encode0
in a special way. (0 can be encoded both as0x00
and0x80
)withdrawRoot
fromimportGenesisBatch
isL1MessageRelayed
ScrollMessengerBase
, the slot used inverifyMessageExecutionStatus
andverifyMessageInclusionStatus
should be fixed.WETH9.withdraw
WETH9
code usestransfer
to withdraw ETH, which may run out of gas in some cases.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?