New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contract): add ScrollOwner #586
Conversation
LCOV of commit
|
im not sure what the intention for this contract is, but one way i could see this making sense: use ScrollOwner to replace the forwarder contract (#528). Have an Owner (admin with no timelock) for low value functions, an Admin (security council multisig behind timelock) and superAdmin (scroll multisig behind timelock, which can also change the other roles). i dont think there should be a seperate DEFAULT_ADMIN, its a very powerful role (change other permissions) and to echo Peter, maybe this role should just be the SuperAdmin. Other wise i think the permissions per byte4 make sense will review more closely |
Now only have two roles: |
Purpose or design rationale of this PR
This PR add a
ScrollOwner
contract which has multiple roles to manage other scroll contracts.PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?