Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): OZ-L1-L05 Outdated OpenZeppelin Library Version #622

Merged
merged 5 commits into from Jul 20, 2023

Conversation

Thegaram
Copy link
Contributor

@Thegaram Thegaram commented Jul 6, 2023

Purpose or design rationale of this PR

This PR fix the bug (OZ-L1-L05 Outdated OpenZeppelin Library Version) reported by OpenZeppelin. The following are the details:

The OpenZeppelin library version in use is ^4.5.0 and ^4.5.2 for the upgradeable contracts, while the current release version is 4.9.2. Consider updating the dependency to be safe against any bugs that were patched in the meantime. Make sure to have an extensive test suite testing the integration of the library modules, as some changes may break the existing functionality.

I went through the OZ release notes and it seems none of the changes affect our code.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@Thegaram Thegaram requested review from zimpha and iczc July 6, 2023 14:02
@github-actions
Copy link

github-actions bot commented Jul 6, 2023

LCOV of commit 20d505a during Contracts #1124

Summary coverage rate:
  lines......: 51.3% (894 of 1741 lines)
  functions..: 68.1% (203 of 298 functions)
  branches...: no data found

Files changed coverage rate: n/a

iczc
iczc previously approved these changes Jul 6, 2023
zimpha
zimpha previously approved these changes Jul 7, 2023
@zimpha zimpha dismissed stale reviews from iczc and themself via 6f01b8e July 20, 2023 08:33
@HAOYUatHZ HAOYUatHZ merged commit bae38de into develop Jul 20, 2023
3 checks passed
@HAOYUatHZ HAOYUatHZ deleted the fix-oz-l1-l05 branch July 20, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants