Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contracts): OZ-L1-L04 Lost Funds in Messenger Contracts #637

Merged
merged 2 commits into from
Jul 20, 2023
Merged

fix(contracts): OZ-L1-L04 Lost Funds in Messenger Contracts #637

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c89704c
add onlyOwner modifier in receive fallback of ScrollMessengerBase
zimpha Jul 11, 2023
d369ccb
Merge branch 'develop' into fix/lost_funds_in_messenger_contracts
HAOYUatHZ Jul 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions contracts/src/libraries/ScrollMessengerBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,8 @@ abstract contract ScrollMessengerBase is OwnableUpgradeable, IScrollMessenger {
feeVault = _feeVault;
}

// allow others to send ether to messenger
receive() external payable {}
// make sure only owner can send ether to messenger to avoid possible user fund loss.
receive() external payable onlyOwner {}

/************************
* Restricted Functions *
Expand Down