fix(contracts): OZ-L2-L06 Initialization Performed Outside of Initialization Function

[zimpha]

Purpose or design rationale of this PR

This PR fix the bug (L-06 Initialization Performed Outside of Initialization Function) reported by OpenZeppelin. The following are the details:

The updateMessenger function in L2MessageQueue can only be called before any message is appended, otherwise it will revert since nextMessageIndex is sequentially increased. Therefore, the updateMessenger logic aligns closer with the purpose of the initialize function, rather than a standalone function.

Consider moving the logic of updateMessenger into the initialize function with the onlyOwner modifier. This can be done since the predeployed contracts should exist before L2ScrollMessenger.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

• build: Changes that affect the build system or external dependencies (example scopes: yarn, eslint, typescript)
• ci: Changes to our CI configuration files and scripts (example scopes: vercel, github, cypress)
• docs: Documentation-only changes
• feat: A new feature
• fix: A bug fix
• perf: A code change that improves performance
• refactor: A code change that doesn't fix a bug, or add a feature, or improves performance
• style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
• test: Adding missing tests or correcting existing tests

Deployment tag versioning

Has tag in common/version.go been updated?

• No, this PR doesn't involve a new deployment, git tag, docker image tag
• Yes

Breaking change label

Does this PR have the breaking-change label?

• No, this PR is not a breaking change
• Yes

[github-actions]

LCOV of commit 7ff47bd during Contracts #1178

Summary coverage rate:
  lines......: 52.2% (894 of 1712 lines)
  functions..: 69.8% (203 of 291 functions)
  branches...: no data found

Files changed coverage rate: n/a

[icemelon]

I have a question. Will we ever possibly change the L2ScrollMessenger contract address and need to update it in the L2MessageQueue? @zimpha

[zimpha]

I have a question. Will we ever possibly change the L2ScrollMessenger contract address and need to update it in the L2MessageQueue? @zimpha

We won't update it in normal situation unless we have a very big breaking change. In such case, we can deploy another L2MessageQueue.