New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(contracts): add rate limiter #712
Conversation
LCOV of commit
|
Codecov upload limit reached
|
Would it be better to add the rate limiter only for L2->L1 withdrawals? |
If the address of the rate limiter is not set, then there will be no limit. So, we can controll to add or not during initialization. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add rateLimiter
address to relay message blacklist.
https://github.com/scroll-tech/scroll/blob/v4.1.58/contracts/src/L1/L1ScrollMessenger.sol#L150
https://github.com/scroll-tech/scroll/blob/v4.1.58/contracts/src/L2/L2ScrollMessenger.sol#L166
Purpose or design rationale of this PR
This PR add a rate limiter for deposit/withdraw ETH and ERC20 tokens in scroll messengers and gateways.
PR title
Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:
Deployment tag versioning
Has
tag
incommon/version.go
been updated?Breaking change label
Does this PR have the
breaking-change
label?