Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(contracts): foundry scripts for ScrollOwner #838

Merged
merged 38 commits into from Sep 21, 2023
Merged

feat(contracts): foundry scripts for ScrollOwner #838

merged 38 commits into from Sep 21, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Aug 21, 2023

Purpose or design rationale of this PR

This PR add deployment and initialization scripts for ScrollOwner contract. The access is configured by this doc.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • feat: A new feature

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change

@zimpha zimpha force-pushed the feat/scroll_owner_deploy_and_initialize branch from a09e044 to 3a7a74c Compare August 21, 2023 05:07
@zimpha zimpha self-assigned this Aug 21, 2023
@zimpha zimpha marked this pull request as ready for review September 1, 2023 03:26
@github-actions
Copy link

github-actions bot commented Sep 1, 2023 •
edited

LCOV of commit 8e59a2e during Contracts #84

Summary coverage rate:
  lines......: 51.6% (1014 of 1966 lines)
  functions..: 65.2% (227 of 348 functions)
  branches...: no data found

Files changed coverage rate: n/a

Thegaram
Thegaram previously approved these changes Sep 1, 2023
View reviewed changes
Thegaram
Thegaram previously approved these changes Sep 7, 2023
View reviewed changes
Thegaram
Thegaram previously approved these changes Sep 8, 2023
View reviewed changes
@iczc
Copy link
Contributor

iczc commented Sep 8, 2023

Do we need to configure the owner for ratelimit contracts?

@zimpha
Copy link
Member Author

zimpha commented Sep 11, 2023

Do we need to configure the owner for ratelimit contracts?

Yes, we need.

@Thegaram
Copy link
Contributor

Thegaram commented Sep 12, 2023 •
edited

Update updateTokenMapping to 1 day.

@Thegaram Thegaram merged commit 4d903bc into develop Sep 21, 2023
4 checks passed
@Thegaram Thegaram deleted the feat/scroll_owner_deploy_and_initialize branch September 21, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@icemelon icemelon icemelon left review comments

@iczc iczc iczc left review comments

@Thegaram Thegaram Thegaram approved these changes

@HAOYUatHZ HAOYUatHZ Awaiting requested review from HAOYUatHZ

Assignees

@zimpha zimpha

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@zimpha @iczc @Thegaram @icemelon