Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): check actual number of transactions in each chunk #887

Merged
merged 5 commits into from Sep 1, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Aug 30, 2023

Purpose or design rationale of this PR

This PR check the actual number of transactions in each chunk instead of only L2 transactions, which is consistent with batch proposer and zkevm circuits.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha added the bug Something isn't working label Aug 30, 2023
@zimpha zimpha self-assigned this Aug 30, 2023
@zimpha zimpha requested review from Thegaram, HAOYUatHZ, icemelon and iczc and removed request for Thegaram August 30, 2023 03:45
@github-actions
Copy link

github-actions bot commented Aug 30, 2023

LCOV of commit c9effa3 during Contracts #1340

Summary coverage rate:
  lines......: 52.6% (992 of 1885 lines)
  functions..: 67.3% (222 of 330 functions)
  branches...: no data found

Files changed coverage rate: n/a

colinlyguo
colinlyguo previously approved these changes Aug 31, 2023
Thegaram
Thegaram previously approved these changes Aug 31, 2023
contracts/src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
contracts/src/L1/rollup/ScrollChain.sol Outdated Show resolved Hide resolved
@zimpha zimpha dismissed stale reviews from Thegaram and colinlyguo via c9effa3 September 1, 2023 03:14
@icemelon icemelon merged commit 8daa5d5 into develop Sep 1, 2023
@icemelon icemelon deleted the feat/bound_both_l1_and_l2_tx_on_commit_batch branch September 1, 2023 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants