Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): OZ-L02 Utilizing Deprecated Function From Library #902

Merged

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Sep 1, 2023

Purpose or design rationale of this PR

This PR partially fixed the issue reported by Openzepplin (L-02 Utilizing Deprecated Function From Library) during ScrollOwner and Rate Limiter audit. The following are the details:

The TokenRateLimiter contract is setting up its default admin role in the constructor using the _setupRole function. However, this function has been deprecated.

To avoid potential future incompatibilities with OpenZeppelin's contracts library, consider using the _grantRole method instead.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version tag to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha added the bug Something isn't working label Sep 1, 2023
@zimpha zimpha self-assigned this Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

LCOV of commit 0861e03 during Contracts #1375

Summary coverage rate:
  lines......: 52.6% (992 of 1885 lines)
  functions..: 67.3% (222 of 330 functions)
  branches...: no data found

Files changed coverage rate: n/a

@HAOYUatHZ HAOYUatHZ merged commit 255eb5f into develop Sep 1, 2023
4 checks passed
@HAOYUatHZ HAOYUatHZ deleted the fix/OZ-L02_utilizing_deprecated_function_from_library branch September 1, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants