Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): OZ-N01 Variable Cast is Unnecessary #903

Merged
merged 2 commits into from Sep 1, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Sep 1, 2023

Purpose or design rationale of this PR

This PR partially fixed the issue reported by Openzepplin (N-01 Variable Cast is Unnecessary) during ScrollOwner and Rate Limiter audit. The following are the details:

Within the ScrollOwner contract, the _target variable in the _execute function was unnecessarily cast.

To improve the overall clarity, intent, and readability of the codebase, consider removing this unnecessary cast.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version tag to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha added the bug Something isn't working label Sep 1, 2023
@zimpha zimpha self-assigned this Sep 1, 2023
@zimpha zimpha changed the title fix(contracts): OZ N-01 Variable Cast is Unnecessary fix(contracts): OZ-N01 Variable Cast is Unnecessary Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

LCOV of commit e4f6895 during Contracts #1372

Summary coverage rate:
  lines......: 52.6% (992 of 1885 lines)
  functions..: 67.3% (222 of 330 functions)
  branches...: no data found

Files changed coverage rate: n/a

@HAOYUatHZ HAOYUatHZ merged commit 07961f7 into develop Sep 1, 2023
3 checks passed
@HAOYUatHZ HAOYUatHZ deleted the fix/OZ-N01_variable_cast_is_unnecessary branch September 1, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants