Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): OZ-N02 Incorrect Function Visibility #904

Merged
merged 2 commits into from Sep 1, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Sep 1, 2023

Purpose or design rationale of this PR

This PR partially fixed the issue reported by Openzepplin (N-02 Incorrect Function Visibility) during ScrollOwner and Rate Limiter audit. The following are the details:

In the ScrollOwner contract, the execute function is marked as public, while the _execute function has internal visibility.

The execute function should be marked as external because it is not called internally by any of the functions in the ScrollOwner contract.

The _execute function should be marked as private because it is implemented in the top-level ScrollOwner contract and is not intended to be called by the derived contracts. To improve the overall clarity, intent, and readability of the codebase, consider fixing the visibility for these functions.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version tag to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha added the bug Something isn't working label Sep 1, 2023
@zimpha zimpha self-assigned this Sep 1, 2023
@github-actions
Copy link

github-actions bot commented Sep 1, 2023

LCOV of commit e780334 during Contracts #1370

Summary coverage rate:
  lines......: 52.6% (992 of 1885 lines)
  functions..: 67.3% (222 of 330 functions)
  branches...: no data found

Files changed coverage rate: n/a

@HAOYUatHZ HAOYUatHZ merged commit bbd5a5a into develop Sep 1, 2023
3 checks passed
@HAOYUatHZ HAOYUatHZ deleted the fix/OZ-N02_incorrect_function_visibility branch September 1, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants