Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(contracts): OZ-L02 Lack of gap Variable #929

Merged
merged 2 commits into from Sep 11, 2023

Conversation

zimpha
Copy link
Member

@zimpha zimpha commented Sep 6, 2023

Purpose or design rationale of this PR

This PR fixed the issue reported by Openzepplin (L-01 Misleading Comment) during Scroll USDC Gateway audit. The following are the details:

The CCTPGatewayBase contract does not contain a gap variable although it is upgradeable.

Consider adding a gap variable following OpenZeppelin's upgradeable contracts guide to avoid future storage collisions.

PR title

Your PR title must follow conventional commits (as we are doing squash merge for each PR), so it must start with one of the following types:

  • fix: A bug fix

Deployment tag versioning

Has tag in common/version.go been updated or have you added bump-version label to this PR?

  • No, this PR doesn't involve a new deployment, git tag, docker image tag
  • Yes

Breaking change label

Does this PR have the breaking-change label?

  • No, this PR is not a breaking change
  • Yes

@zimpha zimpha added the bug Something isn't working label Sep 6, 2023
@zimpha zimpha self-assigned this Sep 6, 2023
@github-actions
Copy link

github-actions bot commented Sep 6, 2023

LCOV of commit 47db95a during Contracts #31

Summary coverage rate:
  lines......: 51.6% (1013 of 1963 lines)
  functions..: 65.6% (227 of 346 functions)
  branches...: no data found

Files changed coverage rate: n/a

@HAOYUatHZ HAOYUatHZ merged commit 4d3ff66 into develop Sep 11, 2023
4 checks passed
@HAOYUatHZ HAOYUatHZ deleted the fix/OZ-L02_Lack_of_gap_Variable branch September 11, 2023 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants