Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc-test in busmapping has to be disabled #782

Open
noel2004 opened this issue Aug 16, 2023 · 0 comments
Open

Doc-test in busmapping has to be disabled #782

noel2004 opened this issue Aug 16, 2023 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@noel2004
Copy link
Member

PR #767 enable CircuitBuilder in busmapping setting up a full witness building from l2 trace (including mpt). As the result, busmapping would depend on mpt-zktrie crate and it cause doc-test can not be run since zktrie has induced a shared library dependence for libzktrie.so.

This is a Cargo issue which affect doc-test only (common lib test is not affected). Current we have no suitable way to remedy the problem except for adding no_run attr on the doc test, which stop the doc-test being run.

Prepare the libzktrie.so and specify the LD_LIBRARY_PATH for the path of the shared libs can also be a work-around but it is not recommended for CI. We may have some ways to handle this issue in the future if Cargo can not fix their issue yet:

  1. We can make use some features and specify zktrie being built as static library under testing
  2. The plan for a rust-base zktrie may also be a resultion.
@lispc lispc added the documentation Improvements or additions to documentation label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants