-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comment lines lile "/* x */" results in /*[> x <] */, thus uncomment it result in [> x <]. #170
Comments
I'm having the same issue. |
Same here |
Same here. It did work in an older version I used (don't know which) |
My PR has fixed this issue. |
Thanks for reviewing your PR @knight42, but I'm not sure this is actually fixed. I tested the example @pengubco let off with and I get a different result, but still broken. The nested comment placeholders aren't getting placed, but this causes the comment nesting to break. The real fix would be to set the placeholders, but also unset them appropriately. Would your patch actually do this correctly? Or does in actually work now and I'm missing something? |
@alerque The problem we encountered before is that if the following lines are uncommented,
we' ll get
But using the latest
Could I know the different result in your test? |
@knight42 I get the same result for that particular case of uncommenting. The issue I see is with commenting it in the first place. For reference given this file with int n = 3;
/*call function asynchronously:*/
std::future<bool> fut = std::async (is_prime,n);
std::cout<< n << std::endl; Selecting everything and commenting it using the simple block method ( /* int n = 3;
/*call function asynchronously:*/
std::future<bool> fut = std::async (is_prime,n);
std::cout<< n << std::endl; */ |
Oh, I see what's different. I have If anybody has anything to add or a case that isn't working, please comment and we'll reevaluate. |
I have a habit of commenting a single line using /* */. For example, using [leader]cm.
When I need to comment these comment-lines out (for debugging) and then getting these comment-lines back after. I got a bunch of [> my comment lines <].
For example,
Run [leader]cm in visual select mode results in ,
The text was updated successfully, but these errors were encountered: