Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing whitespace for top and bottom line #269

Merged
merged 1 commit into from
Nov 15, 2016

Conversation

chipironcin
Copy link
Contributor

Remove trailing whitespace for top and bottom line when uncommenting a sexy commented block.
Fixes #268

Remove trailing whitespace for top and bottom line when uncommenting a sexy commented block.
Fixes preservim#268
@alerque
Copy link
Member

alerque commented Sep 22, 2016

Thanks for the contribution. I'll review this for real next week when I'm not on the road. In the mean time have you checked whether it plays nice with the various user facing settings for how to handle spaces? How about Python and the current snafu going on in this plugin with the PEP8 comment standard?

@chipironcin
Copy link
Contributor Author

chipironcin commented Sep 22, 2016

I have not checked anything about that, definitively will do.
Anyways this change is not that disruptive, I am just removing the trailing whitespace not only for the inner lines in the block but for the first/last lines too.

@alerque alerque merged commit ecdde21 into preservim:master Nov 15, 2016
@alerque
Copy link
Member

alerque commented Nov 15, 2016

Sorry this took me so long to get back to, but it's merged now. Thanks again for the contribution @chipironcin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants