Secret Foundation Tax #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexanderbez
commented
Aug 28, 2020
alexanderbez
commented
Aug 28, 2020
assafmo
reviewed
Aug 31, 2020
|
This is ready for review again. |
|
Docs update PR: scrtlabs/SecretNetwork#518 |
assafmo
reviewed
Sep 1, 2020
assafmo
approved these changes
Sep 2, 2020
Closed
4 tasks
toml01
reviewed
Sep 2, 2020
assafmo
pushed a commit
that referenced
this pull request
Jul 12, 2021
* require old chain halts before upgrade * Update proto/ibc/core/client/v1/client.proto Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> * start address reviews * Apply suggestions from code review Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> * address reviews * rework upgrade to ensure there is never more than one upgrade client in store * fix tests * fix conditional * make proto-gen * remove if statement skipping tests in upgrade keeper test * address reviews * correctly escape and unescape merkle keys * add small conditional check Co-authored-by: Federico Kunze <31522760+fedekunze@users.noreply.github.com> Co-authored-by: colin axnér <25233464+colin-axner@users.noreply.github.com> Co-authored-by: Colin Axner <colinaxner@berkeley.edu>
assafmo
added a commit
to scrtlabs/SecretNetwork
that referenced
this pull request
Jul 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Modification of
x/distributionbased off of rough proposal outlined here which introduces support for a secret foundation tax and governance proposal.TODO:
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerCodecov Reportin the comment section below once CI passes