Skip to content
This repository has been archived by the owner on Jun 21, 2020. It is now read-only.

Move code output from verbosity level 2 to 3 #177

Closed
lacabra opened this issue Jun 15, 2019 · 4 comments
Closed

Move code output from verbosity level 2 to 3 #177

lacabra opened this issue Jun 15, 2019 · 4 comments
Assignees

Comments

@lacabra
Copy link
Contributor

lacabra commented Jun 15, 2019

Is your feature request related to a problem? Please describe.
When running the the integration integration test on Travis (and trying to integrate the integration tests with other repos on Travis), Travis reports Log Length exceeded and aborts before the tests finish.

In the current setup core runs with -vv. If I change the verbosity level to -v the tests succeed, but I don't have enough visibility to what core does to be able to troubleshoot.

Describe the solution you'd like
When you choose verbosity level 2 with -vv, when deploying a contract (message Ok(DeploySecretContract...) would not include the output field that contains the bytecode of the deployed contract, but would include all other fields.

The, to display the field above with all others, you would choose -vvv.

@lacabra
Copy link
Contributor Author

lacabra commented Jun 16, 2019

I have been thinking this more thoroughly, and I would like to amend my request as follows:

  • Include the output of deploy and computations in verbosity level 1: -v without the output bytecode. This is the most useful output for debugging purposes most of the time.
  • Leave verbosity level 2: -vv as is.

The rationale is that the rest of stuff that is logged on level 2, clutters the CI and is not that useful when I only need to know whether deploy/computation succeeds, so I would only like to see that in level 1 for the CI, and when I run it manually I can choose level 2 and see everything that I'm seeing now.

@moriaab
Copy link
Contributor

moriaab commented Jun 16, 2019

@lacabra

  1. In this issue, do you mean stdout logs only?
  2. As far as I understand, you want that there will be:
    • some verbosity level L that includes output of deploy and computations without bytecode
    • the next verbosity level L+1 that includes output of deploy and computations with bytecode
  3. I agree with the request, but I am not sure that L should be -v. In core the levels of the debug are compatible with the Rust log package and defined as follows:
    0 - off,
    1 - error,
    2 - warn,
    3 - info,
    4 - debug,
    5 and more - trace
    In addition, in core the log level of stdout is the level defined by a user+1 (the reason for that was that even with no verbose, errors will be printed to stdout). Therefore, -vmeans warn level. I think that L level should be at least info.

@moriaab
Copy link
Contributor

moriaab commented Jun 19, 2019

@lacabra
I merged the change. Please see if the issue can be closed.

@lacabra
Copy link
Contributor Author

lacabra commented Jul 10, 2019

I confirm that this has been resolved in #179. Thank you!

@lacabra lacabra closed this as completed Jul 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants