This repository has been archived by the owner on Jun 21, 2020. It is now read-only.
Moving log of bytecode returning from deploy_contract function from info to debug level #179
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moriaab
changed the title
moriaab
changed the title
AvishaiW
approved these changes
Jun 19, 2019
| @@ -353,9 +351,16 @@ pub(self) mod handling { | |||
| // Save the ExeCode into the DB. | |||
| let key = DeltaKey::new(contract_address, Stype::ByteCode); | |||
| db.create(&key, &v.output)?; | |||
| Ok(v.into_deploy_response(&bytecode)) | |||
| let wasm_result = v.into_deploy_response(&bytecode); | |||
There was a problem hiding this comment.
wasm_result is not a good name since it contains an IpcResponse
Co-Authored-By: Avishai Weingarten <33716232+AvishaiW@users.noreply.github.com>
Co-Authored-By: Avishai Weingarten <33716232+AvishaiW@users.noreply.github.com>
lacabra
added a commit
that referenced
this pull request
Jul 10, 2019
AvishaiW
added a commit
that referenced
this pull request
Jul 10, 2019
MAINT: adj verbosity after #179
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The result returned from
deploy_contractfunction contains bytecode, which may be huge. I moved it from info to debug level.