Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cosmwasm-v1 does not pass secret-contract-optimizer #32

Closed
HS-Joe opened this issue Sep 12, 2022 · 4 comments
Closed

cosmwasm-v1 does not pass secret-contract-optimizer #32

HS-Joe opened this issue Sep 12, 2022 · 4 comments

Comments

@HS-Joe
Copy link

HS-Joe commented Sep 12, 2022

As specified in the documentation, we should run enigmampc/secret-contract-optimizer before storing the contract.
On the branch cosmwasm-v1 it currently fails with

error[E0407]: method `provide` is not a member of trait `std::error::Error`
Error:  --> /home/runner/.cargo/git/checkouts/cosmwasm-4588eb921f8fdfe2/f7e2b1d/packages/std/src/errors/recover_pubkey_error.rs:8:10
  |
8 | #[derive(Error, Debug)]
  |          ^^^^^ not a member of trait `std::error::Error`
  |
  = note: this error originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info)

Error:  --> /home/runner/.cargo/git/checkouts/cosmwasm-4588eb921f8fdfe2/f7e2b1d/packages/std/src/errors/verification_error.rs:9:10
  |
9 | #[derive(Error, Debug)]
  |          ^^^^^ not a member of trait `std::error::Error`
  |
  = note: this error originates in the derive macro `Error` (in Nightly builds, run with -Z macro-backtrace for more info)

error[E0412]: cannot find type `Demand` in module `std::any`

[...]

Should we stick to the optimisation in the Makefile?

@HS-Joe
Copy link
Author

HS-Joe commented Sep 12, 2022

Probably due to enigmampc/secret-contract-optimizer using rust 1.62 instead of 1.63

@assafmo
Copy link
Member

assafmo commented Sep 14, 2022

Can you try with enigmampc/secret-contract-optimizer:1.0.9?

@HS-Joe
Copy link
Author

HS-Joe commented Sep 14, 2022

@assafmo Oh didn't see this release! It work fine with it, thanks. Closing the issue.

@HS-Joe HS-Joe closed this as completed Sep 14, 2022
@assafmo
Copy link
Member

assafmo commented Sep 15, 2022

Thank, also tagged it as latest which should make that docs work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants