Skip to content

Commit

Permalink
rename baseparamsbuilder to DefaultAdditionalParams
Browse files Browse the repository at this point in the history
  • Loading branch information
haerdib committed Jan 3, 2023
1 parent 5ce5ed7 commit 0971d2f
Show file tree
Hide file tree
Showing 5 changed files with 13 additions and 13 deletions.
4 changes: 2 additions & 2 deletions examples/examples/compose_extrinsic_offline.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use kitchensink_runtime::{BalancesCall, Runtime, RuntimeCall};
use sp_keyring::AccountKeyring;
use sp_runtime::{generic::Era, MultiAddress};
use substrate_api_client::{
rpc::JsonrpseeClient, Api, AssetTipExtrinsicParams, BaseExtrinsicParamsBuilder, GetHeader,
rpc::JsonrpseeClient, Api, AssetTipExtrinsicParams, DefaultAdditionalParams, GetHeader,
SubmitAndWatch, XtStatus,
};

Expand All @@ -45,7 +45,7 @@ async fn main() {
let last_finalized_header_hash = api.get_finalized_head().unwrap().unwrap();
let header = api.get_header(Some(last_finalized_header_hash)).unwrap().unwrap();
let period = 5;
let tx_params = BaseExtrinsicParamsBuilder::new()
let tx_params = DefaultAdditionalParams::new()
.era(Era::mortal(period, header.number.into()), last_finalized_header_hash)
.tip(0);

Expand Down
4 changes: 2 additions & 2 deletions examples/examples/custom_nonce.rs
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ use kitchensink_runtime::{BalancesCall, Runtime, RuntimeCall};
use sp_keyring::AccountKeyring;
use sp_runtime::{generic::Era, MultiAddress};
use substrate_api_client::{
rpc::JsonrpseeClient, Api, AssetTipExtrinsicParams, BaseExtrinsicParamsBuilder, GetHeader,
rpc::JsonrpseeClient, Api, AssetTipExtrinsicParams, DefaultAdditionalParams, GetHeader,
SubmitAndWatch, XtStatus,
};

Expand All @@ -41,7 +41,7 @@ async fn main() {
let last_finalized_header_hash = api.get_finalized_head().unwrap().unwrap();
let header = api.get_header(Some(last_finalized_header_hash)).unwrap().unwrap();
let period = 5;
let tx_params = BaseExtrinsicParamsBuilder::new()
let tx_params = DefaultAdditionalParams::new()
.era(Era::mortal(period, header.number.into()), last_finalized_header_hash)
.tip(0);

Expand Down
10 changes: 5 additions & 5 deletions primitives/src/extrinsic_params.rs
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,14 @@ pub struct BaseExtrinsicParams<Tip, Index, Hash> {
/// This builder allows you to provide the parameters that can be configured in order to
/// construct a [`BaseExtrinsicParams`] value.
#[derive(Decode, Encode, Copy, Clone, Eq, PartialEq, Debug)]
pub struct BaseExtrinsicParamsBuilder<Tip, Hash> {
pub struct DefaultAdditionalParams<Tip, Hash> {
era: Era,
mortality_checkpoint: Option<Hash>,
tip: Tip,
}

impl<Tip: Default, Hash> BaseExtrinsicParamsBuilder<Tip, Hash> {
/// Instantiate the default set of [`BaseExtrinsicParamsBuilder`]
impl<Tip: Default, Hash> DefaultAdditionalParams<Tip, Hash> {
/// Instantiate the default set of [`DefaultAdditionalParams`]
pub fn new() -> Self {
Self::default()
}
Expand All @@ -139,7 +139,7 @@ impl<Tip: Default, Hash> BaseExtrinsicParamsBuilder<Tip, Hash> {
}
}

impl<Tip: Default, Hash> Default for BaseExtrinsicParamsBuilder<Tip, Hash> {
impl<Tip: Default, Hash> Default for DefaultAdditionalParams<Tip, Hash> {
fn default() -> Self {
Self { era: Era::Immortal, mortality_checkpoint: None, tip: Tip::default() }
}
Expand All @@ -153,7 +153,7 @@ where
Hash: HashTrait + Encode + Copy,
DefaultSignedExtra<Tip, Index>: Encode,
{
type AdditionalParams = BaseExtrinsicParamsBuilder<Tip, Hash>;
type AdditionalParams = DefaultAdditionalParams<Tip, Hash>;
type SignedExtra = DefaultSignedExtra<Tip, Index>;
type AdditionalSigned = DefaultAdditionalSigned<Hash>;

Expand Down
4 changes: 2 additions & 2 deletions primitives/src/extrinsics.rs
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ fn encode_with_vec_prefix<T: Encode, F: Fn(&mut Vec<u8>)>(encoder: F) -> Vec<u8>
#[cfg(test)]
mod tests {
use super::*;
use crate::{BaseExtrinsicParams, BaseExtrinsicParamsBuilder, ExtrinsicParams, PlainTip};
use crate::{BaseExtrinsicParams, DefaultAdditionalParams, ExtrinsicParams, PlainTip};
use sp_core::{Pair, H256 as Hash};
use sp_runtime::{generic::Era, testing::sr25519, MultiSignature};

Expand All @@ -155,7 +155,7 @@ mod tests {
let signature = pair.sign(msg);
let multi_sig = MultiSignature::from(signature);
let account: AccountId = pair.public().into();
let tx_params = BaseExtrinsicParamsBuilder::<PlainTip<u128>, Hash>::new()
let tx_params = DefaultAdditionalParams::<PlainTip<u128>, Hash>::new()
.era(Era::mortal(8, 0), Hash::from([0u8; 32]));

let default_extra = BaseExtrinsicParams::new(0, 0, 0u32, Hash::from([0u8; 32]), tx_params);
Expand Down
4 changes: 2 additions & 2 deletions src/api/api_client.rs
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ where
mod tests {
use super::*;
use crate::{
rpc::mocks::RpcClientMock, utils::ToHexString, BaseExtrinsicParamsBuilder,
rpc::mocks::RpcClientMock, utils::ToHexString, DefaultAdditionalParams,
PlainTipExtrinsicParams,
};
use kitchensink_runtime::Runtime;
Expand Down Expand Up @@ -299,7 +299,7 @@ mod tests {
create_mock_api(genesis_hash, runtime_version.clone(), metadata, Default::default());

// Information for Era for mortal transactions.
let builder = BaseExtrinsicParamsBuilder::new();
let builder = DefaultAdditionalParams::new();
api.set_extrinsic_params_builder(builder);

let nonce = 6;
Expand Down

0 comments on commit 0971d2f

Please sign in to comment.