Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support 32bit architectures #477

Closed
Niederb opened this issue Mar 22, 2023 · 0 comments · Fixed by #478
Closed

Support 32bit architectures #477

Niederb opened this issue Mar 22, 2023 · 0 comments · Fixed by #478
Assignees

Comments

@Niederb
Copy link
Contributor

Niederb commented Mar 22, 2023

The api-client does currently not compile for 32bit architectures. As wasm typically compiles to 32bit we have to fix this first in order to continue with #272 .
The issue is due to a missing BitStore implementation for u64 on for 32bit architectures
See ferrilab/bitvec#75 and https://docs.rs/bitvec/latest/src/bitvec/store.rs.html#194
Compile error:

error[E0277]: the trait bound `u64: BitStore` is not satisfied
   --> node-api/src/decoder/decode.rs:285:58
    |
285 |         (BitOrderTy::U64, BitStoreTy::Lsb0) => to_bit_sequence(BitVec::<u64, Lsb0>::decode(data)?),
    |                                                                ^^^^^^^^^^^^^^^^^^^ the trait `BitStore` is not implemented for `u64`

error[E0599]: no method named `encode_to` found for struct `BitVec` in the current scope
   --> node-api/src/decoder/encode.rs:567:53
    |
567 |             bools.into_iter().collect::<BitVec<u64, Msb0>>().encode_to(bytes);
    |                                                              ^^^^^^^^^ method not found in `BitVec<u64, Msb0>`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant