Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some system helper functions #402

Merged
merged 3 commits into from
Jan 3, 2023
Merged

Add some system helper functions #402

merged 3 commits into from
Jan 3, 2023

Conversation

haerdib
Copy link
Contributor

@haerdib haerdib commented Dec 30, 2022 •
edited
Loading

Tests printed the following:

System name: Substrate Node
System version: 3.0.0-dev-ed82c874b9c
System chain: Development
System chain type: Development
System properties: {}
System health: 0 peers (idle)
System local peer id: "12D3KooWBaP3Yvpv59X7P9jznQJ1WJ2PqJGg26rm5pMm8V2v6Duj"
System local listen addresses: ["/ip4/127.0.0.1/tcp/30333/p2p/12D3KooWBaP3Yvpv59X7P9jznQJ1WJ2PqJGg26rm5pMm8V2v6Duj", "/ip4/172.17.0.2/tcp/30333/p2p/12D3KooWBaP3Yvpv59X7P9jznQJ1WJ2PqJGg26rm5pMm8V2v6Duj"]

closes #223

@haerdib haerdib added F7-enhancement Enhances an already existing functionality E1-breaksnothing labels Dec 30, 2022
@haerdib haerdib self-assigned this Dec 30, 2022
@haerdib haerdib changed the title Add system helper functions Add some system helper functions Dec 30, 2022
@haerdib haerdib marked this pull request as ready for review December 30, 2022 13:17
clangenb
clangenb approved these changes Jan 2, 2023
View reviewed changes
Copy link
Collaborator

@clangenb clangenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, these are valuable!

@haerdib haerdib merged commit 5cfedac into master Jan 3, 2023
@haerdib haerdib deleted the bh/helper-system-properties branch January 3, 2023 08:32
@haerdib haerdib mentioned this pull request Jan 4, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clangenb clangenb clangenb approved these changes

Assignees

@haerdib haerdib

Labels
E1-breaksnothing F7-enhancement Enhances an already existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Is there any helper for system_properties?
2 participants
@haerdib @clangenb