Implement balance_transfer_keep_alive #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Niederb
force-pushed
the
tn/balance_transfer_keep_alive
branch
from
02e1e61
to
f9f4a4b
Compare
masapr
requested changes
Jul 8, 2024
|
|
||
| let _ed = api.get_existential_deposit().await.unwrap(); | ||
| let ed = api.get_existential_deposit().await.unwrap(); |
There was a problem hiding this comment.
I think the focus of this test is sending funds, therefore I would make a new test-file with a fitting name. Also I would test a successfull transaction with balance_transfer_keep_alive.
I would create 2 new tests:
- "send_funds_test.rs" that tests a successfull balance_transfer_keep_alive transaction
- "send_funds_with_death_test.rs" for the test case here.
There was a problem hiding this comment.
I agree with adding a successful transaction for balance_transfer_keep_alive but I would keep it all in the same file it is now. The reason is that so far the testing examples are more organized by pallet/subsystem (frame_system_tests.rs, pallet_contract_tests.rs, chain_tests.rs, ....) and not by a specific test case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.