Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the status output format with some improvements for brevity and understanding:
scsiencrypt.h
are now declared withstd::array
to make it a one-liner in modern C++ to rtrim and print them.Drive input: Encrypting
withWriting: Encrypting
andDrive output: Decrypting
withReading: Encrypting
. This better matches how a tape drive is typically used in a UNIX command or pipe (since "Drive input" refers the action that is done when the drive is used as the output file of command such asdd if=src of=/dev/nst0
)Volume Encryption: Encrypted
toCurrent block status: Encrypted
. "Volume" is not a term used inmt
or other tape programs. The SCSI data is being printed is actually called "next block encryption status" since it refers to the block following the current tape position.Other changes:
output.cpp
updated for new outputscsiencrypt.cpp
debug output with a new functionprint_buffer
. Including in this PR to reduce merge conflicts.Follow-on PR with fixing include headers using
include-what-you-use
to follow.