Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The handling of / is not spec compliant #146

Open
stof opened this issue Aug 18, 2020 · 4 comments
Open

The handling of / is not spec compliant #146

stof opened this issue Aug 18, 2020 · 4 comments
Labels
spec compliance Issues with compliance to the Sass spec
Milestone

Comments

@stof
Copy link
Member

stof commented Aug 18, 2020

Lots of specs are failing because / always computes a division, while it should not be the case (and both libsass and dart-sass agree on this)

@Cerdic
Copy link
Collaborator

Cerdic commented Aug 18, 2020

Yes we use some empirical rule instead of the sasslang heuristic
https://sass-lang.com/documentation/operators/numeric#slash-separated-values

@navindex
Copy link

For example the media query @media (min-aspect-ratio: 5/8) will be translated to @media (min-aspect-ratio: 0.625) and it will be completely ignored by Chrome.

@navindex
Copy link

For those who have a similar issue: @media (unquote("#{5}/#{8}")) workaround helped. I expected the #{5}/#{8} expression will be translated to 5/8, however, it didn't work.

@stof stof added the spec compliance Issues with compliance to the Sass spec label Nov 3, 2020
@stof
Copy link
Member Author

stof commented May 1, 2021

I expected the #{5}/#{8} expression will be translated to 5/8, however, it didn't work.

yeah, because our implementation of interpolation is not spec compliant either...

@stof stof added this to the 2.0 milestone Oct 2, 2021
eliot-akira added a commit to TangibleInc/template-system that referenced this issue Mar 8, 2024
- Resolves #85
- Add tests for edge cases
- Known issue with handling of slashes in CSS values
  - scssphp/scssphp#146
  - See #82 - Workaround is to use `unquote('..')`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec compliance Issues with compliance to the Sass spec
Projects
None yet
Development

No branches or pull requests

3 participants