Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework SassSpecTest to read hrx and identify specs in the same way than the official runner #255

Open
stof opened this issue Nov 6, 2020 · 0 comments

Comments

@stof
Copy link
Member

stof commented Nov 6, 2020

Currently, we rely on the sass-spec convention of separating tests with a delimiter comment to identify the different specs. This causes issues when the convention is not properly respected (see #254), which happens as there is no linter enforcing the convention in sass-spec for now.
We should instead read the hrx file properly to identify files and folders in it, and identify specs based on folders containing a input.scss or input.sass file (and then skipping the ones with input.sass as we don't support the sass syntax).

This can either be done adhoc in SassSpecTest or by implementing a HRX reader and then using it in SassSpecTest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant