Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): in Settings > Services, make Radarr/Sonarr server names and logos clickable links #1008

Merged
merged 3 commits into from Mar 4, 2021

Conversation

TheCatLady
Copy link
Collaborator

@TheCatLady TheCatLady commented Feb 23, 2021

Description

I personally would appreciate an easier way to navigate directly to the Radarr/Sonarr instance from the settings page. 😉 Also display the full address, including scheme (http/https) and port, and removed usage of FormattedMessage.

Screenshot (if UI-related)

image

To-Dos

  • Successful build yarn build

Issues Fixed or Closed

N/A

@TheCatLady TheCatLady requested a review from sct as a code owner February 23, 2021 12:12
@TheCatLady TheCatLady force-pushed the feature/ui/settings-services-ext-url-links branch 8 times, most recently from 7e94e62 to 18d23a3 Compare March 2, 2021 13:13
@TheCatLady TheCatLady changed the title feat(ui): in Settings > Services, make Radarr/Sonarr logos clickable links if external URL is set feat(ui): in Settings > Services, make Radarr/Sonarr server names and logos clickable links Mar 2, 2021
@TheCatLady TheCatLady force-pushed the feature/ui/settings-services-ext-url-links branch from 18d23a3 to ae1bb2d Compare March 3, 2021 22:55
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@sct sct enabled auto-merge (squash) March 3, 2021 23:36
@TheCatLady TheCatLady force-pushed the feature/ui/settings-services-ext-url-links branch from ae1bb2d to 332b691 Compare March 3, 2021 23:46
@TheCatLady TheCatLady force-pushed the feature/ui/settings-services-ext-url-links branch from 332b691 to d997d85 Compare March 3, 2021 23:54
@sct sct merged commit 6a1e389 into develop Mar 4, 2021
@sct sct deleted the feature/ui/settings-services-ext-url-links branch March 4, 2021 00:18
@github-actions
Copy link

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants