Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(docker): add tini to container image #1017

Merged
merged 2 commits into from Mar 3, 2021
Merged

feat(docker): add tini to container image #1017

merged 2 commits into from Mar 3, 2021

Conversation

onedr0p
Copy link
Contributor

@onedr0p onedr0p commented Feb 23, 2021

Description

Small change here. I created an ENTRYPOINT with tini and updated the CMD in the Dockerfile. tini is already included in the Docker CRI, however some people (like me) use a different CRI like containerd or cri-o where we don't have access to an --init flag.

tini also has other benefits as described in this Github issue.

Screenshot (if UI-related)

N/A

To-Dos

  • Successful build yarn build
  • Translation keys yarn i18n:extract
  • Database migration (if required)

Issues Fixed or Closed

  • Fixes #XXXX

@onedr0p onedr0p requested a review from sct as a code owner February 23, 2021 22:12
sct
sct approved these changes Mar 3, 2021
View reviewed changes
Copy link
Owner

@sct sct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this rebased and we can merge it!

Thanks!

@sct sct enabled auto-merge (squash) March 3, 2021 23:35
@sct sct merged commit 1629d02 into sct:develop Mar 3, 2021
@sct
Copy link
Owner

sct commented Mar 5, 2021

@all-contributors please add @onedr0p for infra

@allcontributors allcontributors bot mentioned this pull request Mar 5, 2021
Merged
@allcontributors
Copy link
Contributor

@sct

I've put up a pull request to add @onedr0p! 🎉

@onedr0p onedr0p deleted the patch-1 branch March 5, 2021 18:01
@github-actions
Copy link

🎉 This PR is included in version 1.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sct sct sct approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@onedr0p @sct