Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(notif): fixed typo in pushover hint #1029

Merged
merged 1 commit into from
Feb 26, 2021

Conversation

danshilm
Copy link
Collaborator

@danshilm danshilm commented Feb 25, 2021

Description

Simple fix for a typo

Screenshot (if UI-related)

None

To-Dos

None

  • Successful build yarn build
  • Ran yarn i18n:extract

Issues Fixed or Closed

  • Fixes none

@danshilm danshilm requested a review from sct as a code owner February 25, 2021 16:06
@TheCatLady
Copy link
Collaborator

Also need to update the strings in en.json. 😉 Thanks for submitting the PR, @danshilm!

@danshilm danshilm force-pushed the bugfix/notif/pushover branch 2 times, most recently from c9a5f11 to b40ce0b Compare February 25, 2021 18:27
@danshilm
Copy link
Collaborator Author

Hmm, i18n:extract didn't update the strings in the locale files, is that normal?
Made the changes in the locale files anyway.

@TheCatLady
Copy link
Collaborator

TheCatLady commented Feb 25, 2021

Hmm, i18n:extract didn't update the strings in the locale files, is that normal?
Made the changes in the locale files anyway.

Due to the way it is configured, yarn i18n:extract will not overwrite existing strings, but only add/remove strings.

@sct sct merged commit e9f2fe9 into sct:develop Feb 26, 2021
@github-actions
Copy link

🎉 This PR is included in version 1.20.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@danshilm danshilm deleted the bugfix/notif/pushover branch March 20, 2021 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants