fix(ui): for server default options, display "All" region/language option instead of empty string #1042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sct
reviewed
Feb 28, 2021
sct
reviewed
Feb 28, 2021
sct
reviewed
Feb 28, 2021
TheCatLady
force-pushed
the
bugfix/ui/empty-default-region-lang
branch
from
016b21f
to
3155d98
Compare
|
Are we missing some changes here now in the region selector? |
TheCatLady
force-pushed
the
bugfix/ui/empty-default-region-lang
branch
from
bff719e
to
3345014
Compare
sct
reviewed
Feb 28, 2021
TheCatLady
force-pushed
the
bugfix/ui/empty-default-region-lang
branch
from
c01ce28
to
6d20f0b
Compare
sct
reviewed
Feb 28, 2021
src/components/UserProfile/UserSettings/UserGeneralSettings/index.tsx
Outdated
Show resolved
Hide resolved
…tion instead of empty string
…ult option when appropriate
TheCatLady
force-pushed
the
bugfix/ui/empty-default-region-lang
branch
from
dad932a
to
320a1ce
Compare
|
🎉 This PR is included in version 1.20.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the server default is not set, the option is currently "Default ()" instead of "Default (All <Regions/Languages>)."
Also, I think the application title is unnecessary here? It can also result in the text not being fully visible if the user-set custom title is too long, so I feel it is best to just omit it.
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
N/A