feat(ui): display "Owner" role instead of "Admin" for user ID 1 #1050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also add role to user settings page, and fix the missing "Account Type" string and use the same verbiage on the user list page
…rom server/lib/permissions
TheCatLady
force-pushed
the
feature/ui/owner-role
branch
from
f17ee20
to
6552cc6
Compare
sct
approved these changes
Mar 2, 2021
|
🎉 This PR is included in version 1.21.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since user ID 1 is special in that it is the only user type which is able to grant "Admin" privileges, we should distinguish this account from "regular" admin accounts.
Also add role to user settings page, and fix the missing "Account Type" string and update the user list page to be consistent ("Account Type" vs "User Type").
Screenshot (if UI-related)
To-Dos
yarn buildyarn i18n:extractIssues Fixed or Closed
N/A